PATCH: dlls/commdlg/printdlg.c add casts

Gerald Pfeifer pfeifer at dbai.tuwien.ac.at
Sat Jun 28 02:46:35 CDT 2003


The following patch to dlls/commdlg/printdlg.c

  revision 1.66
  date: 2003/06/27 22:21:06;  author: julliard;  state: Exp;  lines: +4 -7
  Mike Hearn <m.hearn at signal.qinetiq.com>
  Store PrintStructures in a window property instead of extra window bytes.

cause two new warnings

  printdlg.c:2056: warning: passing arg 2 of `GetPropW' from incompatible pointer type
  printdlg.c:2061: warning: passing arg 2 of `SetPropW' from incompatible pointer type

Is the fix below the proper one?

Gerald

ChangeLog:
Add missing casts in PrintDlgProcW().

Index: printdlg.c
===================================================================
RCS file: /home/wine/wine/dlls/commdlg/printdlg.c,v
retrieving revision 1.66
diff -u -3 -p -r1.66 printdlg.c
--- printdlg.c	27 Jun 2003 22:21:06 -0000	1.66
+++ printdlg.c	28 Jun 2003 07:44:50 -0000
@@ -2053,12 +2053,13 @@ INT_PTR CALLBACK PrintDlgProcW(HWND hDlg
     INT_PTR res = FALSE;

     if (uMsg!=WM_INITDIALOG) {
-	PrintStructures = (PRINT_PTRW*) GetPropW(hDlg, "__WINE_PRINTDLGDATA");
+	PrintStructures = (PRINT_PTRW*)
+                          GetPropW(hDlg, (LPCWSTR)"__WINE_PRINTDLGDATA");
 	if (!PrintStructures)
 	    return FALSE;
     } else {
         PrintStructures = (PRINT_PTRW*) lParam;
-	SetPropW(hDlg, "__WINE_PRINTDLGDATA", PrintStructures);
+	SetPropW(hDlg, (LPCWSTR)"__WINE_PRINTDLGDATA", PrintStructures);
 	res = PRINTDLG_WMInitDialogW(hDlg, wParam, PrintStructures);

 	if(PrintStructures->dlg.lpPrintDlg->Flags & PD_ENABLEPRINTHOOK)



More information about the wine-patches mailing list