module->addr_sorttab may be NULL due to a hack in elf_new_wine_thunks

Dmitry Timoshkov dmitry at baikal.ru
Sun Aug 8 07:53:07 CDT 2004


Hello,

this patch fixes a crash in dbghelp and helps to avoid recursive attempts
to start winedbg. The crash occurs while loading symbols and is caused by
the hack in elf_new_wine_thunks which sets module->sortlist_valid to TRUE.

Changelog:
    Dmitry Timoshkov <dmitry at codeweavers.com>
    module->addr_sorttab may be NULL due to a hack in elf_new_wine_thunks.

--- cvs/hq/wine/dlls/dbghelp/symbol.c	2004-07-10 08:37:57.000000000 +0900
+++ wine/dlls/dbghelp/symbol.c	2004-08-08 21:05:52.000000000 +0900
@@ -612,7 +612,10 @@ int symt_find_nearest(struct module* mod
     int         mid, high, low;
     DWORD       ref_addr, ref_size;
 
-    if (!module->sortlist_valid && !resort_symbols(module)) return -1;
+    if (!module->sortlist_valid || !module->addr_sorttab)
+    {
+        if (!resort_symbols(module)) return -1;
+    }
 
     /*
      * Binary search to find closest symbol.






More information about the wine-patches mailing list