SHELL32: clean up messy comment in SHFileOperation (with patch this time)

Mike McCormack mike at codeweavers.com
Sun Aug 15 05:35:21 CDT 2004


ChangeLog:
* clean up messy comment in SHFileOperation
-------------- next part --------------
Index: dlls/shell32/shlfileop.c
===================================================================
RCS file: /home/wine/wine/dlls/shell32/shlfileop.c,v
retrieving revision 1.41
diff -u -r1.41 shlfileop.c
--- dlls/shell32/shlfileop.c	23 Jul 2004 23:02:09 -0000	1.41
+++ dlls/shell32/shlfileop.c	15 Aug 2004 02:38:58 -0000
@@ -862,19 +862,29 @@
          * copy files to dir       1 0 1 1 0 0 1 0
          * create dir              0 0 0 0 0 0 1 0
          */
-/*
- * FOF_MULTIDESTFILES, FOF_NOCONFIRMATION, FOF_FILESONLY  are implemented
- * FOF_CONFIRMMOUSE, FOF_SILENT, FOF_NOCONFIRMMKDIR,
- *       FOF_SIMPLEPROGRESS, FOF_NOCOPYSECURITYATTRIBS    are not implemented and ignored
- * FOF_RENAMEONCOLLISION                                  are implemented partially and breaks if file exist
- * FOF_ALLOWUNDO, FOF_WANTMAPPINGHANDLE                   are not implemented and breaks
- * if any other flag set, an error occurs
- */
+
+        /*
+         * Summary of flags:
+         *
+         * implemented flags:
+         * FOF_MULTIDESTFILES, FOF_NOCONFIRMATION, FOF_FILESONLY
+         *
+         * unimplememented and ignored flags:
+         * FOF_CONFIRMMOUSE, FOF_SILENT, FOF_NOCONFIRMMKDIR,
+         *       FOF_SIMPLEPROGRESS, FOF_NOCOPYSECURITYATTRIBS
+         *
+         * partially implemented, breaks if file exists:
+         * FOF_RENAMEONCOLLISION
+         *
+         * unimplemented and break if any other flag set:
+         * FOF_ALLOWUNDO, FOF_WANTMAPPINGHANDLE
+         */
+
         TRACE("%s level=%ld nFileOp.fFlags=0x%x\n", 
                 debug_shfileops_action(FuncSwitch), level, lpFileOp->fFlags);
 
-/*    OFl &= (-1 - (FOF_MULTIDESTFILES | FOF_FILESONLY)); */
-/*    OFl ^= (FOF_SILENT | FOF_NOCONFIRMATION | FOF_SIMPLEPROGRESS | FOF_NOCONFIRMMKDIR); */
+        /*    OFl &= (-1 - (FOF_MULTIDESTFILES | FOF_FILESONLY)); */
+        /*    OFl ^= (FOF_SILENT | FOF_NOCONFIRMATION | FOF_SIMPLEPROGRESS | FOF_NOCONFIRMMKDIR); */
         OFl &= (~(FOF_MULTIDESTFILES | FOF_NOCONFIRMATION | FOF_FILESONLY));  /* implemented */
         OFl ^= (FOF_SILENT | FOF_NOCONFIRMMKDIR | FOF_NOERRORUI | FOF_NOCOPYSECURITYATTRIBS); /* ignored, if one */
         OFl &= (~FOF_SIMPLEPROGRESS);                      /* ignored, only with FOF_SILENT */


More information about the wine-patches mailing list