PATCH: fix recent dlls/ntdll/sec.c change

Francois Gouget fgouget at free.fr
Mon Aug 16 02:12:05 CDT 2004


On Sun, 15 Aug 2004, Gerald Pfeifer wrote:
[...]
>    sec.c:365: warning: invalid application of `sizeof' to a void type
>
> And in fact, this is not just a warning -- that code seems to be
> completely broken, for PSECURITY_DESCRIPTOR is just a typedef for PVOID.
>
> And please, pretty please, use current versions of GCC to test all
> patches, and do NOT just ignore warnings.  Surprisingly often, these
> indicate real programming errors!

I'm using Debian Testing's compiler: gcc 3.3.4 and unfortunately it
doesn't print any warning there.


> ChangeLog:
> Fix incorrect sizeof in RtlCreateSecurityDescriptor().

Looks good. I had missed the sizeof(*lpsd). Hopefully I didn't miss
others.


-- 
Francois Gouget         fgouget at free.fr        http://fgouget.free.fr/
               Dieu dit: "M-x Lumi\xE8re". Et la lumi\xE8re fut.



More information about the wine-patches mailing list