Limit number of DirectDrawClipper_SetClipList FIXMEs

Tobias Burnus burnus at gmx.de
Fri Aug 20 11:37:40 CDT 2004


Using the Cambridge Advanced Learner's Dictionary, thousands of
   fixme:ddraw:Main_DirectDrawClipper_SetClipList 
(0x403990a8,0x4067dda0,0),stub!
are shown. Do the same as in GetClipList: Limit the number of warnings 
to 10. Add some comments and change pdwSize to pdwFlag to match MSDN.

Tobias


Changelog:
   - Limit number of FIXME()s in Clipper_SetClipList and document function


Index: dlls/ddraw/dclipper/main.c
===================================================================
RCS file: /home/wine/wine/dlls/ddraw/dclipper/main.c,v
retrieving revision 1.10
diff -u -r1.10 main.c
--- dlls/ddraw/dclipper/main.c  12 Aug 2004 23:01:04 -0000      1.10
+++ dlls/ddraw/dclipper/main.c  20 Aug 2004 16:36:06 -0000
@@ -135,11 +135,27 @@
      return DDERR_NOCLIPLIST;
  }

+/***********************************************************************
+*           IDirectDrawClipper::SetClipList (DDRAW.@)
+*
+* Sets or deletes (if lprgn is NULL) the clip list
+*
+* 
http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/ddraw7/directdraw7/ddref_3wl3.asp
+*
+* PARAMS
+*  lprgn   Pointer to a LRGNDATA structure or NULL
+*  dwFlags not used, must be 0
+* RETURNS
+*  Either DD_OK or DDERR_*
+*/
+
  HRESULT WINAPI Main_DirectDrawClipper_SetClipList(
-    LPDIRECTDRAWCLIPPER iface,LPRGNDATA lprgn,DWORD pdwSize
+    LPDIRECTDRAWCLIPPER iface,LPRGNDATA lprgn,DWORD pdwFlag
  ) {
      ICOM_THIS(IDirectDrawClipperImpl,iface);
-    FIXME("(%p,%p,%ld),stub!\n",This,lprgn,pdwSize);
+    static int warned = 0;
+    if (warned++ < 10 && lprgn != NULL)
+        FIXME("(%p,%p,%ld),stub!\n",This,lprgn,pdwFlag);
      return DD_OK;
  }

Index: dlls/ddraw/dclipper/main.h
===================================================================
RCS file: /home/wine/wine/dlls/ddraw/dclipper/main.h,v
retrieving revision 1.2
diff -u -r1.2 main.h
--- dlls/ddraw/dclipper/main.h  9 Mar 2002 23:29:35 -0000       1.2
+++ dlls/ddraw/dclipper/main.h  20 Aug 2004 16:36:06 -0000
@@ -34,7 +34,7 @@
                                    LPRGNDATA lprgn,LPDWORD pdwSize);
  HRESULT WINAPI
  Main_DirectDrawClipper_SetClipList(LPDIRECTDRAWCLIPPER iface,LPRGNDATA 
lprgn,
-                                  DWORD pdwSize);
+                                  DWORD pdwFlag);
  HRESULT WINAPI
  Main_DirectDrawClipper_QueryInterface(LPDIRECTDRAWCLIPPER iface, 
REFIID riid,
                                       LPVOID* ppvObj);




More information about the wine-patches mailing list