[QUARTZ] Small fix in RenderFile

Christian Costa titan.costa at wanadoo.fr
Sat Dec 4 07:14:33 CST 2004


Hi,

Changelog:
Better handling of errors in RenderFile.

Christian Costa   titan.costa at wanadoo.fr

-------------- next part --------------
Index: filtergraph.c
===================================================================
RCS file: /home/wine/wine/dlls/quartz/filtergraph.c,v
retrieving revision 1.18
diff -u -r1.18 filtergraph.c
--- filtergraph.c	19 Nov 2004 18:17:27 -0000	1.18
+++ filtergraph.c	4 Dec 2004 12:08:38 -0000
@@ -949,7 +949,8 @@
     }
 
     /* Render all output pin of the splitter by calling IGraphBuilder_Render on each of them */
-    hr = GetInternalConnections(psplitter, ppinsplitter, &ppins, &nb);
+    if (SUCCEEDED(hr))
+        hr = GetInternalConnections(psplitter, ppinsplitter, &ppins, &nb);
     
     if (SUCCEEDED(hr)) {
         int i;
@@ -963,10 +964,10 @@
                 break;
             }
         }
+        CoTaskMemFree(ppins);
     }
-    CoTaskMemFree(ppins);
     
-    return S_OK;
+    return hr;
 }
 
 static HRESULT WINAPI Graphbuilder_AddSourceFilter(IGraphBuilder *iface,


More information about the wine-patches mailing list