ITSS: DllCanUnloadNow implementation
Jacek Caban
jack at itma.pwr.wroc.pl
Fri Dec 31 05:12:47 CST 2004
Robert Shearman wrote:
> Jacek Caban wrote:
>
>> Changelog:
>> Implemented DllCanUnloadNow
>
>
>
>>
>> BOOL WINAPI ITSS_DllCanUnloadNow(void)
>> {
>> - FIXME("\n");
>> -
>> - return FALSE;
>> + TRACE("dll_count = %lu\n", dll_count);
>> + return !dll_count;
>>
>>
>
> This function should return an HRESULT, not a BOOL. This error would
> have been caught if it weren't for the silly ITSS_ prefix.
> Consequently, the return value should be either S_OK or S_FALSE
> depending on whether there are no or some remaining references
> respectively.
>
> Rob
>
I've fixed this bug. The prior existting BOOL in function declaration
suggested it. Thanks.
Have a Happy New Year!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itss2.diff
Type: text/x-patch
Size: 7488 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20041231/756d7db6/itss2.bin
More information about the wine-patches
mailing list