breakpoint management in winedbg

Eric Pouech pouech-eric at wanadoo.fr
Tue Jan 27 14:15:21 CST 2004


change log says it all
A+
-------------- next part --------------
Name:          wd_bp
ChangeLog:     
	-now reporting message on bogus line number in 'bp <num>' commands (useful when user thinks <num> is a linear address)
	- fixed bogus return value in DEBUG_AddBreakpoint
License:       X11
GenDate:       2004/01/27 20:14:34 UTC
ModifiedFiles: programs/winedbg/break.c
===================================================================
RCS file: /home/cvs/cvsroot/wine/wine/programs/winedbg/break.c,v
retrieving revision 1.3
diff -u -u -r1.3 break.c
--- programs/winedbg/break.c	15 Dec 2003 19:53:08 -0000	1.3
+++ programs/winedbg/break.c	26 Jan 2004 21:21:20 -0000
@@ -368,7 +368,7 @@
 			TRUE );
     DEBUG_Printf("\n");
 
-    return FALSE;
+    return TRUE;
 }
 
 /***********************************************************************
@@ -472,12 +472,17 @@
             DEBUG_Printf("Unable to add breakpoint\n");
             return;
         }
-        DEBUG_GetLineNumberAddr(nh, lineno, &value.addr, TRUE);
+        if (!DEBUG_GetLineNumberAddr(nh, lineno, &value.addr, TRUE))
+        {
+            DEBUG_Printf("Unknown line number\n"
+                         "(either out of file, or no code at given line number)\n");
+            return;
+        }
     }
 
     value.type = NULL;
     value.cookie = DV_TARGET;
-    DEBUG_AddBreakpoint( &value,NULL, TRUE );
+    DEBUG_AddBreakpoint( &value, NULL, TRUE );
 }
 
 /***********************************************************************


More information about the wine-patches mailing list