WineHQ:winetest:refuse default build IDs

[Ferenc Wagner]

ChangeLog: Refuse uploads carrying the default build ID.

Feri.

Index: winetest/winetest.cgi
===================================================================
RCS file: /home/wine/tools/winetest/winetest.cgi,v
retrieving revision 1.4
diff -u -r1.4 winetest.cgi
--- winetest/winetest.cgi	15 Mar 2004 18:31:01 -0000	1.4
+++ winetest/winetest.cgi	21 Jul 2004 10:32:43 -0000
@@ -34,8 +34,9 @@
 sub test_reportfile {
     my $buffer;
     my $fh = upload "reportfile";
-    read $fh, $buffer, 64;
-    $buffer =~ /^Version \d+\r?\nTests from build /s;
+    read $fh, $buffer, 1024;
+    $buffer =~ /^Version \d+\r?\nTests from build ([-.0-9a-zA-Z]+)\r?\n/s;
+    return $1;
 }
 
 sub move_file {
@@ -56,10 +57,13 @@
     if ($error) {
         print "Error: $error\n";
     } elsif ($name) {
-        if (test_reportfile $name) {
-            print move_file $name;
-        } else {
+        my $build = test_reportfile $name;
+        if (!defined $build) {
             print "Error: submission corrupted";
+        } elsif ($build eq "-") {
+            print "Error: build ID unset";
+        } else {
+            print move_file $name;
         }
     }
     exit;
@@ -82,10 +86,13 @@
     print h2 ("Error during file upload ($name)"),
       strong ($error);
 } elsif ($name) {
-    if (test_reportfile $name) {
-        print h2 move_file $name;
+    my $build = test_reportfile $name;
+    if (!defined $build) {
+        print h2 ("Error: submission corrupted");
+    } elsif ($build eq "-") {
+        print h2 ("Error: build ID unset");
     } else {
-        print h2 "Error: submission corrupted";
+        print h2 (move_file $name);
     }
 }
 print end_html;