QuickTime 3.0.1 installer causes crash in windows/dialog.c

[Sami Aario]

Hi,

I tried running the QuickTime 3.0.1 installer under wine and it crashed.
Debugging reveals that the crash occurs in DIALOG_CreateIndirect
(windows/dialog.c): the pointer returned by DIALOG_get_info is not checked,
and the QT installer causes it to be NULL. Presumably this is an application
error, because the attached patch returning 0 for error allows the installer
to
continue. However, I am not sure if this patch is appropriate.

Anyhow, an application error should not cause wine to crash, and I'll see if
I
can recreate this behavior and submit a regression test if I can.

ChangeLog:
In DIALOG_CreateIndirect, check the validity of the pointer returned by
DIALOG_get_info.

--
Sami
-------------- next part --------------
Index: dialog.c
===================================================================
RCS file: /home/wine/wine/windows/dialog.c,v
retrieving revision 1.130
diff -u -r1.130 dialog.c
--- dialog.c	18 May 2004 20:45:22 -0000	1.130
+++ dialog.c	22 Jun 2004 18:43:01 -0000
@@ -634,6 +634,12 @@
     will be valid only after WM_CREATE message has been handled in DefDlgProc
     All the members of the structure get filled here using temp variables */
     dlgInfo = DIALOG_get_info(hwnd);
+    
+    if (!dlgInfo)
+    {
+        return 0;
+    }
+    
     dlgInfo->hwndFocus   = 0;
     dlgInfo->hUserFont   = hUserFont;
     dlgInfo->hMenu       = hMenu;