Access Violation in SHBrowseForFolder

woschwot at onlinehome.de woschwot at onlinehome.de
Sat Mar 13 16:33:56 CST 2004


Subject: Access Violation in SHBrowseForFolder
Description: It's not documented in MSDN but SHBrowseForFolder supports
             lpBrowseInfo->pszDisplayName = NULL. In this case Wine
             currently responds with an access violation when pressing
             OK in the Shell Browse Folder. The patch avoids this.
ChangeLog: In SHBrowseForFolder support lpBrowseInfo->pszDisplayName to 
be NULL

--- wine-20040309.orig/dlls/shell32/brsfolder.c 2004-03-13 
22:33:50.000000000 +00
100
+++ wine-20040309/dlls/shell32/brsfolder.c      2004-03-13 
22:28:27.000000000 +00
100
@@ -391,7 +391,8 @@
            switch (wParam)
            { case IDOK:
                pdump ( pidlRet );
-               SHGetPathFromIDListW(pidlRet, lpBrowseInfo->pszDisplayName);
+               if (lpBrowseInfo->pszDisplayName)
+                   SHGetPathFromIDListW(pidlRet, 
lpBrowseInfo->pszDisplayName);
                EndDialog(hWnd, (DWORD) ILClone(pidlRet));
                return TRUE;





More information about the wine-patches mailing list