Assume MAX_PATH length for pszDisplayName

Uwe Bonnes bon at elektron.ikp.physik.tu-darmstadt.de
Thu May 27 05:46:48 CDT 2004


Changelog:
	dlls/shell32/brsfolders.c: SHBrowseForFolderA
	LPBROWSEINFOA->pszDisplayName is assumed to have MAX_PATH legth

Fixes a crash in Xilinx ISE when vreating a new project with a long path

-- 
Uwe Bonnes                bon at elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
Index: wine/dlls/shell32/brsfolder.c
===================================================================
RCS file: /home/wine/wine/dlls/shell32/brsfolder.c,v
retrieving revision 1.51
diff -u -w -5 -r1.51 brsfolder.c
--- wine/dlls/shell32/brsfolder.c	19 Apr 2004 20:12:14 -0000	1.51
+++ wine/dlls/shell32/brsfolder.c	26 May 2004 13:56:29 -0000
@@ -460,11 +460,12 @@
 	bi.hwndOwner = lpbi->hwndOwner;
 	bi.pidlRoot = lpbi->pidlRoot;
 	if (lpbi->pszDisplayName)
 	{
 	  len = MultiByteToWideChar(CP_ACP, 0, lpbi->pszDisplayName, -1, NULL, 0);
-	  bi.pszDisplayName = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
+	  /*lpbi->pszDisplayName is assumed to be MAX_PATH (MSDN) */
+	  bi.pszDisplayName = HeapAlloc(GetProcessHeap(), 0, MAX_PATH * sizeof(WCHAR));
 	  MultiByteToWideChar(CP_ACP, 0, lpbi->pszDisplayName, -1, bi.pszDisplayName, len);
 	}
 	else
 	  bi.pszDisplayName = NULL;
 



More information about the wine-patches mailing list