winapi_check and 16 bit -register functions
Francois Gouget
fgouget at free.fr
Fri Oct 22 10:44:25 CDT 2004
Yesterday's winapi_check path warns about 32 bit -register functions
that are implemented by stdcall functions, but not about 16 bit
-register functions implemented by stdcall functions. The reason is that
for the latter the calling convention is set to 'pascal' or 'pascal16'
in winapi_check. However I suspect these too should be implemented as
cdecl. So here's a patch to warn about them and if it is applied I'll
send a patch tomorrow to fix the new set of warnings.
Changelog:
* tools/winapi_check/winapi_local.pm
Also warn about 16 bit -register APIs that are implemented by stdcall
functions.
--
Francois Gouget fgouget at free.fr http://fgouget.free.fr/
"Lotto: A tax on people who are bad at math." -- unknown
"Windows: Microsoft's tax on computer illiterates." -- WE7U
-------------- next part --------------
Index: tools/winapi_check/winapi_local.pm
===================================================================
RCS file: /var/cvs/wine/tools/winapi_check/winapi_local.pm,v
retrieving revision 1.41
diff -u -r1.41 winapi_local.pm
--- tools/winapi_check/winapi_local.pm 21 Oct 2004 20:58:13 -0000 1.41
+++ tools/winapi_check/winapi_local.pm 22 Oct 2004 09:47:45 -0000
@@ -158,7 +158,7 @@
if ($declared_register)
{
- if ($implemented_calling_convention eq "stdcall")
+ if ($implemented_calling_convention =~ /^(?:stdcall|pascal|pascal16)$/)
{
$output->write("-register functions should not be implemented as stdcall\n");
}
More information about the wine-patches
mailing list