shellpath.c: Avoid copying invalid data on error

Juan Lang juan_lang at yahoo.com
Fri Oct 22 16:13:39 CDT 2004


The following patch misses one source of possible
failure, if _SHExpandEnvironmentStrings fails:
http://www.winehq.org/hypermail/wine-cvs/2004/10/0309.html

The following is a better patch, I think, in that
- it doesn't add a break statement to the default case
(some compilers warn on this)
- it corrects the invalid data case by 1) initializing
szTemp and 2) checking hr just before the copy

ChangeLog: Avoid copying invalid data on error


--Juan


		
_______________________________
Do you Yahoo!?
Declare Yourself - Register online to vote today!
http://vote.yahoo.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shellpath.diff
Type: text/x-patch
Size: 1176 bytes
Desc: shellpath.diff
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20041022/5c8782b4/shellpath.bin


More information about the wine-patches mailing list