winemenubuilder error handling
Francois Gouget
fgouget at codeweavers.com
Fri Apr 15 05:18:36 CDT 2005
winemenubuilder can be given a list of .lnk files to handle. However
currently it quits as soon as it has a problem with one of them. For
instance if it fails to create the 3 menu out of ten, then it stops
there. This does not make sense to me since it already created some
menus and yet will ignore the remaining, presumably perfectly valid,
menus. Instead it would make more sense for it to create all the menus
it can and have the return code indicate a failure if there was a
problem with any of them.
Changelog:
* programs/winemenubuilder/winemenubuilder.c
Francois Gouget <fgouget at codeweavers.com>
If winemenubuilder is given a list of menus to recreate, it should
not give up on the first menu that fails.
--
Francois Gouget
fgouget at codeweavers.com
-------------- next part --------------
Index: programs/winemenubuilder/winemenubuilder.c
===================================================================
RCS file: /var/cvs/wine/programs/winemenubuilder/winemenubuilder.c,v
retrieving revision 1.26
diff -u -p -r1.26 winemenubuilder.c
--- programs/winemenubuilder/winemenubuilder.c 22 Feb 2005 19:31:19 -0000 1.26
+++ programs/winemenubuilder/winemenubuilder.c 15 Apr 2005 10:02:06 -0000
@@ -1010,7 +1010,6 @@ int PASCAL WinMain (HINSTANCE hInstance,
{
WINE_ERR( "failed to build menu item for %s\n",token);
ret = 1;
- break;
}
}
}
More information about the wine-patches
mailing list