Ugly dclipper winapi_check hack

Francois Gouget fgouget at free.fr
Wed Apr 20 04:29:36 CDT 2005


winapi_check assumes that all the functions declared in a given spec 
file are implemented in a C file located in the same directory. This 
seems to hold true except for DirectDrawCreateClipper() which is 
implemented in a sub-directory.

This causes winapi_check to not notice the DirectDrawCreateClipper() 
implementation and to complain that it's missing. So I hacked it so it 
also takes into account C files located in ddraw/dclipper/ for 
ddraw.spec.

If anyone has an idea for a better fix (or if you know of other APIs 
that should have the same problem) I'm all ears as I don't like this 
solution much.


Changelog:

  * tools/winapi_check/modules.pm

    Francois Gouget <fgouget at free.fr>
    Hack so winapi_check finds the DirectDrawCreateClipper() 
implementation in ddraw/dclipper/main.c.


-- 
Francois Gouget         fgouget at free.fr        http://fgouget.free.fr/
           tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY
-------------- next part --------------
Index: tools/winapi_check/modules.pm
===================================================================
RCS file: /var/cvs/wine/tools/winapi_check/modules.pm,v
retrieving revision 1.24
diff -u -p -r1.24 modules.pm
--- tools/winapi_check/modules.pm	30 Oct 2004 02:11:19 -0000	1.24
+++ tools/winapi_check/modules.pm	19 Apr 2005 15:14:43 -0000
@@ -112,6 +112,7 @@ sub find_spec_files($) {
         $$spec_file2dir{$spec_file}{$allowed_dir}++;
         $$dir2spec_file{$allowed_dir}{$spec_file}++;
     }
+    $$dir2spec_file{"dlls/ddraw/dclipper"}{"dlls/ddraw/ddraw.spec"}++;
 
     return $spec_file_found;
 }


More information about the wine-patches mailing list