No subject

rc = SetFileAttributes("fff", FILE_ATTRIBUTE_NORMAL |
FILE_ATTRIBUTE_READONLY );

_is_ valid and sets readonly. In the msdn "However, all other values
override FILE_ATTRIBUTE_NORMAL."

The wine code (files\file.c) prints a fixme if anything is set alongside
attribute_normal:
    if (attributes & FILE_ATTRIBUTE_NORMAL) {
      attributes &= ~FILE_ATTRIBUTE_NORMAL;
      if (attributes)
        FIXME("(%s):%lx illegal combination with FILE_ATTRIBUTE_NORMAL.\n",
lpFileName,attributes);
    }

The following patch removes this check altogether, alternatively you could
change the FIXME to a TRACE or WARN, but I dont see the point in issuing
error messages to the user for possibly valid situations

Changelog:
- Silence fixme in unnecessary situation, add missing \n to another fixme

Jason



------=_NextPart_000_0002_01C203FD.65D7DCD0
Content-Type: application/octet-stream;
	name="bug446.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="bug446.patch"

Index: file.c=0A=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
RCS file: /home/wine/wine/files/file.c,v=0A=
retrieving revision 1.145=0A=
diff -u -r1.145 file.c=0A=
--- file.c	26 Apr 2002 18:31:19 -0000	1.145=0A=
+++ file.c	25 May 2002 14:00:40 -0000=0A=
@@ -813,11 +813,6 @@=0A=
         return FALSE;=0A=
 =0A=
     TRACE("(%s,%lx)\n",lpFileName,attributes);=0A=
-    if (attributes & FILE_ATTRIBUTE_NORMAL) {=0A=
-      attributes &=3D ~FILE_ATTRIBUTE_NORMAL;=0A=
-      if (attributes)=0A=
-        FIXME("(%s):%lx illegal combination with =
FILE_ATTRIBUTE_NORMAL.\n", lpFileName,attributes);=0A=
-    }=0A=
     if(stat(full_name.long_name,&buf)=3D=3D-1)=0A=
     {=0A=
         FILE_SetDosError();=0A=
@@ -840,7 +835,7 @@=0A=
     if (attributes & FILE_ATTRIBUTE_DIRECTORY)=0A=
     {=0A=
         if (!S_ISDIR(buf.st_mode))=0A=
-            FIXME("SetFileAttributes expected the file '%s' to be a =
directory",=0A=
+            FIXME("SetFileAttributes expected the file '%s' to be a =
directory\n",=0A=
                   lpFileName);=0A=
         attributes &=3D ~FILE_ATTRIBUTE_DIRECTORY;=0A=
     }=0A=

------=_NextPart_000_0002_01C203FD.65D7DCD0--