dsound: reactivate tests that now work

moregan at stresscafe.com moregan at stresscafe.com
Mon Aug 15 10:08:26 CDT 2005


Tests commented out and FIXME-ed long ago now pass.  Confirmed with the
author that them working is now expected behavior.

Mike O'Regan
moregan at stresscafe.com

Index: tests/ds3d.c
===================================================================
RCS file: /home/wine/wine/dlls/dsound/tests/ds3d.c,v
retrieving revision 1.27
diff -u -r1.27 ds3d.c
--- tests/ds3d.c        15 Jul 2005 16:34:04 -0000      1.27
+++ tests/ds3d.c        15 Aug 2005 15:05:49 -0000
@@ -471,8 +471,6 @@
             ok(ref==1,"IDirectSoundBuffer_Release() has %d references, "
                "should have 1\n",ref);

-#if 0
-            /* FIXME: this works on windows */
             ref=IDirectSoundBuffer_Release(dsbo);
             ok(ref==0,"IDirectSoundBuffer_Release() has %d references, "
                "should have 0\n",ref);
@@ -482,7 +480,6 @@
                                                    (LPVOID *)&dsbo);
             ok(rc==DS_OK &&
dsbo!=NULL,"IDirectSound3DBuffer_QueryInterface() "
                "failed: %s\n",DXGetErrorString8(rc));
-#endif

             /* DSOUND: Error: Invalid buffer */
             rc=IDirectSound3DBuffer_GetAllParameters(buffer,0);
cvs server: I know nothing about tests/ds3d.o
cvs server: I know nothing about tests/ds3d.ok
Index: tests/ds3d8.c
===================================================================
RCS file: /home/wine/wine/dlls/dsound/tests/ds3d8.c,v
retrieving revision 1.19
diff -u -r1.19 ds3d8.c
--- tests/ds3d8.c       20 Jun 2005 14:18:04 -0000      1.19
+++ tests/ds3d8.c       15 Aug 2005 15:05:50 -0000
@@ -357,8 +357,6 @@
             ok(ref==1,"IDirectSoundBuffer_Release() has %d references, "
                "should have 1\n",ref);

-#if 0
-            /* FIXME: this works on windows */
             ref=IDirectSoundBuffer_Release(dsbo);
             ok(ref==0,"IDirectSoundBuffer_Release() has %d references, "
                "should have 0\n",ref);
@@ -367,8 +365,7 @@
                                                    &IID_IDirectSoundBuffer,
                                                    (LPVOID *)&dsbo);
             ok(rc==DS_OK &&
dsbo!=NULL,"IDirectSound3DBuffer_QueryInterface() "
-               "failed: %s\n",DXGetErrorString8(rc),
-#endif
+               "failed: %s\n",DXGetErrorString8(rc));

             /* DSOUND: Error: Invalid buffer */
             rc=IDirectSound3DBuffer_GetAllParameters(buffer,0);





More information about the wine-patches mailing list