Remove unnecessary #pragma code_page(xxxx) statements from winefile .rc files

Dmitry Timoshkov dmitry at baikal.ru
Sun Aug 21 22:49:26 CDT 2005


"Yuri Kozlov" <kozlov.y at gmail.com> wrote:

> Second, on my machine (debian, UTF-8 locale) winefile compiled with
> options UNICODE
...
> and without #pragma option I have broken menu in winefile.
> Other wine programs is OK.
> 
> May I post screenshot in the list ? (Dmitry, I sent it to you privatly.)


This is because 'LANGUAGE LANG_xxxx' statements don't actually change
code page specified by a previous '#pragma code_page(xxxx)', therefore
russian resources get translated to unicode using wrong code page.
I don't know whether it's an rc bug or a feature. We either need
to remove '#pragma code_page' statements altogether, or add them
to all included .rc files. I took the 1st approach.

Changelog:
    Dmitry Timoshkov <dmitry at codeweavers.com>
    Remove unnecessary #pragma code_page(xxxx) statements from
    winefile .rc files, they confuse the resource compiler.

diff -up cvs/hq/wine/programs/winefile/Cs.rc wine/programs/winefile/Cs.rc
--- cvs/hq/wine/programs/winefile/Cs.rc	2005-06-21 16:40:09.000000000 +0900
+++ wine/programs/winefile/Cs.rc	2005-08-22 12:00:22.000000000 +0900
@@ -23,8 +23,6 @@
  */
 
 LANGUAGE LANG_CZECH, SUBLANG_DEFAULT
-#pragma code_page(1250)
-
 
 /* Menu */
 
diff -up cvs/hq/wine/programs/winefile/De.rc wine/programs/winefile/De.rc
--- cvs/hq/wine/programs/winefile/De.rc	2005-07-04 15:10:22.000000000 +0900
+++ wine/programs/winefile/De.rc	2005-08-22 12:00:28.000000000 +0900
@@ -22,8 +22,6 @@
  */
 
 LANGUAGE LANG_GERMAN, SUBLANG_GERMAN
-#pragma code_page(1252)
-
 
 /* Menu */
 
diff -up cvs/hq/wine/programs/winefile/En.rc wine/programs/winefile/En.rc
--- cvs/hq/wine/programs/winefile/En.rc	2005-06-21 16:40:09.000000000 +0900
+++ wine/programs/winefile/En.rc	2005-08-22 12:00:33.000000000 +0900
@@ -22,8 +22,6 @@
  */
 
 LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
-#pragma code_page(850)
-
 
 /* Menu */
 
diff -up cvs/hq/wine/programs/winefile/Sv.rc wine/programs/winefile/Sv.rc
--- cvs/hq/wine/programs/winefile/Sv.rc	2005-06-21 16:40:09.000000000 +0900
+++ wine/programs/winefile/Sv.rc	2005-08-22 12:01:16.000000000 +0900
@@ -20,8 +20,6 @@
  */
 
 LANGUAGE LANG_SWEDISH, SUBLANG_DEFAULT
-#pragma code_page(1252)
-
 
 /* Menu */
 






More information about the wine-patches mailing list