Preliminary CD-Rom support on MacOS X #5 (take 2)
emmanuel maillard
e.rsz at libertysurf.fr
Fri Dec 30 11:51:31 CST 2005
Hi,
Le 30 déc. 05 à 01:39, Markus Amsler a écrit :
> Hi,
>
> I took a look at your patches, here's what i've found:
>
> ntdll_cdrom.diff:
>
>> #
>>
>> @ cdecl MODULE_DllThreadAttach(ptr)
>> @ cdecl MODULE_GetLoadOrderW(ptr wstr wstr)
>> +@ cdecl CDROM_InitCDDevices()
>> +@ cdecl CDROM_FoundDevices()
>> +@ cdecl CDROM_BSDPathForMedia(ptr)
>> +@ cdecl CDROM_GetMountPointForBSDDevice(ptr)
>> +@ cdecl CDROM_BSDPathForHandle(long)
>> \ No newline at end of file
>
> - You shouldn't add more seperation hacks. Besides that, if _APPLE_
> is not defined, the linker doesn't find these symbols.
I tried to reduce them to the maximum. Sorry about that i correct it
to the attached patch.
> - Gcc spits out warnings about the missing newlines at the end of
> files.
>
> Markus
>
Thanks
Emmanuel
Changelog:
ntdll/cdrom.c, ntdll.spec :
- preliminary CD-Rom support on Darwin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ntdll_cdrom_take2.diff
Type: application/octet-stream
Size: 33506 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20051230/7a055449/ntdll_cdrom_take2-0001.obj
More information about the wine-patches
mailing list