MSI: Correctly ensure properties set from resolved directory paths are backslash terminated

Mike Hearn mh at codeweavers.com
Sat Feb 5 06:42:17 CST 2005


On Sat, 2005-02-05 at 10:53 +0900, Mike McCormack wrote:
> This patch adds way too many TRACEs for my liking.  If you want to add 
> traces to help your understanding, please remove them before submitting 
> the patch.

OK, they were mostly superfluous so I removed them all. Still, a TRACE
("done\n"); at the end of some functions can be useful - a few of them
can generate huge amounts of log output and it took a while to realise
that it was all coming from one function. Marking the end as well as the
beginning helps.

> I also created a function build_directory_name which can do the same 
> thing as your ensure_terminated_by_backslash, so it would be better to 
> use that instead of creating a new function that does the same thing.

Done. Here's the second try.

ChangeLog:
Correctly ensure properties set from resolved directory paths are
backslash terminated


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: text/x-patch
Size: 2592 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20050205/712bb51b/patch.bin


More information about the wine-patches mailing list