PATCH: more error output
Marcus Meissner
marcus at jet.franken.de
Sun Feb 13 15:35:11 CST 2005
Hi,
some more debugoutput lying in my tree.
Ciao, Marcus
Changelog:
Output some more informations.
Mark one global variable static.
Index: dlls/msi/action.c
===================================================================
RCS file: /home/wine/wine/dlls/msi/action.c,v
retrieving revision 1.86
diff -u -r1.86 action.c
--- dlls/msi/action.c 10 Feb 2005 17:09:44 -0000 1.86
+++ dlls/msi/action.c 13 Feb 2005 21:27:42 -0000
@@ -267,7 +267,7 @@
STANDARDACTIONHANDLER handler;
};
-struct _actions StandardActions[] = {
+static struct _actions StandardActions[] = {
{ szAllocateRegistrySpace, NULL},
{ szAppSearch, ACTION_AppSearch },
{ szBindImage, NULL},
@@ -3120,7 +3120,7 @@
rc = ERROR_SUCCESS;
if (rc != ERROR_SUCCESS)
- ERR("Failed to copy file\n");
+ ERR("Failed to copy file %s -> %s, last error %ld\n", debugstr_w(file_source), debugstr_w(dest_path), GetLastError());
FIXME("We should track these duplicate files as well\n");
Index: dlls/ole32/errorinfo.c
===================================================================
RCS file: /home/wine/wine/dlls/ole32/errorinfo.c,v
retrieving revision 1.25
diff -u -r1.25 errorinfo.c
--- dlls/ole32/errorinfo.c 9 Jan 2005 17:29:21 -0000 1.25
+++ dlls/ole32/errorinfo.c 13 Feb 2005 21:27:43 -0000
@@ -386,11 +385,10 @@
LPOLESTR szHelpFile)
{
_ICOM_THIS_From_ICreateErrorInfo(ErrorInfoImpl, iface);
- TRACE("(%p)\n",This);
+ TRACE("(%p,%s)\n",This,debugstr_w(szHelpFile));
if (This->bstrHelpFile != NULL)
ERRORINFO_SysFreeString(This->bstrHelpFile);
This->bstrHelpFile = ERRORINFO_SysAllocString(szHelpFile);
-
return S_OK;
}
@@ -399,9 +397,8 @@
DWORD dwHelpContext)
{
_ICOM_THIS_From_ICreateErrorInfo(ErrorInfoImpl, iface);
- TRACE("(%p)\n",This);
+ TRACE("(%p,%ld)\n",This,dwHelpContext);
This->m_dwHelpContext = dwHelpContext;
-
return S_OK;
}
Index: dlls/shell32/shellpath.c
===================================================================
RCS file: /home/wine/wine/dlls/shell32/shellpath.c,v
retrieving revision 1.97
diff -u -r1.97 shellpath.c
--- dlls/shell32/shellpath.c 10 Feb 2005 19:19:35 -0000 1.97
+++ dlls/shell32/shellpath.c 13 Feb 2005 21:27:45 -0000
@@ -1267,7 +1267,7 @@
}
else
{
- FIXME("LoadString failed, missing translation?\n");
+ FIXME("(%d,%s), LoadString failed, missing translation?\n", folder, debugstr_w(pszPath));
hr = E_FAIL;
}
}
More information about the wine-patches
mailing list