USER32: result of ScrollBar functions review
Vitaly Lipatov
lav at etersoft.ru
Mon Jan 3 05:53:16 CST 2005
I debug some program where under WINE we have scrollbar always showed
in custom window and made some change during review of scroll.c code..
Old SCROLL_GetScrollBarInfo (crossed by name with WinAPI function) is renamed
to SCROLL_GetInternalInfo. SCROLL_GetInternalInfo returns pointer to the
struct only if it already exist. For create struct with scroll bar internal
information we are using SCROLL_NewInternalInfo.
Now we update scroll bar state if we set range first time for value the same
as default value. We DO NOT show scroll bar if only page parameter changing
(check the current state with isShow flag).
When I have learned how to write test I will introduce it :)
ChangeLog
implemented SCROLLBARINFO struct
implemented SBM_GETSCROLLBARINFO message
implemented GetScrollBarInfo function
fix scrollbar show/update conditions
add isShow flag in SCROLLBAR_INFO
rename, separate and rewrite SCROLL_GetScrollBarInfo in to
SCROLL_GetInternalInfo and SCROLL_NewInternalInfo functions
--
Vitaly Lipatov, ALT Linux Team
Russia, Saint-Petersburg, www.etersoft.ru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scroll-review-1.patch
Type: text/x-diff
Size: 21386 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20050103/0cb531bb/scroll-review-1.bin
More information about the wine-patches
mailing list