WineHQ: Janitorial update
Dimitrie O. Paun
dpaun at rogers.com
Sun Jan 9 12:46:04 CST 2005
ChangeLog
More W->A fixes went in.
--
Dimi.
-------------- next part --------------
Index: templates/en/janitorial.template
===================================================================
RCS file: /home/wine/lostwages/templates/en/janitorial.template,v
retrieving revision 1.54
diff -u -r1.54 janitorial.template
--- templates/en/janitorial.template 6 Jan 2005 16:48:31 -0000 1.54
+++ templates/en/janitorial.template 9 Jan 2005 18:44:53 -0000
@@ -129,7 +129,7 @@
<li>dlls/kernel/comm.c: kernel32: SetDefaultCommConfigW: illegal call to SetDefaultCommConfigA
<li>dlls/kernel/locale.c: kernel32: GetLocaleInfoW: illegal call to GetModuleHandleA
<li>dlls/kernel/resource.c: kernel32: FindResourceExW: illegal call to get_res_name_type_WtoA
- <li>dlls/kernel/sync.c: kernel32: WaitNamedPipeW: illegal call to CreateEventA
+ <li class=committed>dlls/kernel/sync.c: kernel32: WaitNamedPipeW: illegal call to CreateEventA
<li>dlls/lzexpand/lzexpand_main.c: lz32: GetExpandedNameW: illegal call to GetExpandedNameA
<li>dlls/lzexpand/lzexpand_main.c: lz32: LZOpenFileW: illegal call to LZOpenFileA
<li>dlls/rpcrt4/rpc_binding.c: rpcrt4: RPCRT4_CreateBindingW: illegal call to RPCRT4_strdupWtoA
@@ -243,16 +243,17 @@
<h3>Getting rid of the global
<font size="-1"><tt>HEAP_strdupWtoA</tt></font> function</h3>
- As of Jan 4, 2005, there were 10 occurrences of <tt>HEAP_strdupWtoA</tt>.
+ As of Jan 9, 2005, there were 11 occurrences of <tt>HEAP_strdupWtoA</tt>.
These functions invocations should go away during the W -> A cross-call
cleanup. It is better to directly fix that sort of cross call, rather than
replace this function by other alternatives. The few of them that can not
be eliminated this way, should be replaced by calls to <tt>WideCharToMultiByte</tt>.<p>
<tt>find dlls -name \*.c -exec grep -q HEAP_strdupWtoA {} \; -ls</tt>
<ul>
- <li>dlls/gdi/printdrv.c
- <li>dlls/wineps/init.c
<li>dlls/winspool/info.c
+ <li>dlls/wineps/escape.c
+ <li>dlls/wineps/init.c
+ <li>windows/clipboard.c
</ul>
When these are finally removed, we can get rid of the non-standard include
file <tt>heap.h</tt>.<p>
More information about the wine-patches
mailing list