[AVIFIL32] Fix wrong logic in acmstream.c and icmstream.c
Paul Vriens
Paul.Vriens at xs4all.nl
Wed Jan 12 11:25:18 CST 2005
Hi,
the functions [ACM|ICM]Stream_fnRelease have the wrong logic regarding
decrementing the reference count.
The fix also includes the change to use Interlocked* as it's a bit
strange to move the non thread-safe This->refs around and fix them in a
second patch.
If this is preferred I will separate the changes.
The fact that the logic is wrong was acknowledged by Michael Günnewig.
Changelog
- fix logic in Stream_fnRelease, refcount should be decremented before
the test for 0.
- use Interlocked* functions in Stream_fnRelease .
- store the result of the Interlocked functions and this in the TRACE.
Cheers,
Paul Vriens.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: avifil32_wrong_logic.diff
Type: text/x-patch
Size: 1827 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20050112/0a98ba03/avifil32_wrong_logic.bin
More information about the wine-patches
mailing list