MSI: lock record in MsiViewExecute, move stubs to end

Mike McCormack mike at codeweavers.com
Thu Jan 20 23:14:47 CST 2005


ChangeLog:
* lock record in MsiViewExecute, move stubs to end
-------------- next part --------------
Index: dlls/msi/msiquery.c
===================================================================
RCS file: /home/wine/wine/dlls/msi/msiquery.c,v
retrieving revision 1.18
diff -u -p -r1.18 msiquery.c
--- dlls/msi/msiquery.c	20 Jan 2005 20:34:29 -0000	1.18
+++ dlls/msi/msiquery.c	21 Jan 2005 05:12:41 -0000
@@ -38,30 +38,6 @@
 
 WINE_DEFAULT_DEBUG_CHANNEL(msi);
 
-#if 0
-typedef struct tagMSIQUERY
-{
-    MSIOBJECTHDR hdr;
-    MSIVIEW *view;
-    UINT row;
-    MSIDATABASE *db;
-} MSIQUERY;
-#endif
-
-UINT WINAPI MsiDatabaseIsTablePersistentA(
-              MSIHANDLE hDatabase, LPSTR szTableName)
-{
-    FIXME("%lx %s\n", hDatabase, debugstr_a(szTableName));
-    return ERROR_CALL_NOT_IMPLEMENTED;
-}
-
-UINT WINAPI MsiDatabaseIsTablePersistentW(
-              MSIHANDLE hDatabase, LPWSTR szTableName)
-{
-    FIXME("%lx %s\n", hDatabase, debugstr_w(szTableName));
-    return ERROR_CALL_NOT_IMPLEMENTED;
-}
-
 void MSI_CloseView( MSIOBJECTHDR *arg )
 {
     MSIQUERY *query = (MSIQUERY*) arg;
@@ -358,7 +334,10 @@ UINT WINAPI MsiViewExecute(MSIHANDLE hVi
         }
     }
 
+    msiobj_lock( &rec->hdr );
     ret = MSI_ViewExecute( query, rec );
+    msiobj_unlock( &rec->hdr );
+
 out:
     if( query )
         msiobj_release( &query->hdr );
@@ -484,5 +463,19 @@ UINT WINAPI MsiViewModify(MSIHANDLE hVie
 hRecord)
 {
     FIXME("%ld %x %ld\n",hView, eModifyMode, hRecord);
+    return ERROR_CALL_NOT_IMPLEMENTED;
+}
+
+UINT WINAPI MsiDatabaseIsTablePersistentA(
+              MSIHANDLE hDatabase, LPSTR szTableName)
+{
+    FIXME("%lx %s\n", hDatabase, debugstr_a(szTableName));
+    return ERROR_CALL_NOT_IMPLEMENTED;
+}
+
+UINT WINAPI MsiDatabaseIsTablePersistentW(
+              MSIHANDLE hDatabase, LPWSTR szTableName)
+{
+    FIXME("%lx %s\n", hDatabase, debugstr_w(szTableName));
     return ERROR_CALL_NOT_IMPLEMENTED;
 }


More information about the wine-patches mailing list