MSI: MsiGetProperty does not return an error on missing properties

Aric Stewart aric at codeweavers.com
Wed Jan 26 21:07:40 CST 2005


MsiGetProperty does not return any error on missing properties.
-------------- next part --------------
Index: dlls/msi/package.c
===================================================================
RCS file: /home/wine/wine/dlls/msi/package.c,v
retrieving revision 1.31
diff -u -u -r1.31 package.c
--- dlls/msi/package.c	25 Jan 2005 20:17:09 -0000	1.31
+++ dlls/msi/package.c	27 Jan 2005 03:08:07 -0000
@@ -844,7 +844,12 @@
         return ERROR_INVALID_HANDLE;
     ret = MSI_GetPropertyA(package, szName, szValueBuf, pchValueBuf );
     msiobj_release( &package->hdr );
-    return ret;
+
+    /* MsiGetProperty does not return error codes on missing properties */
+    if (ret!= ERROR_MORE_DATA)
+        return ERROR_SUCCESS;
+    else
+        return ret;
 }
 
   
@@ -866,5 +871,10 @@
         return ERROR_INVALID_HANDLE;
     ret = MSI_GetPropertyW(package, szName, szValueBuf, pchValueBuf );
     msiobj_release( &package->hdr );
-    return ret;
+
+    /* MsiGetProperty does not return error codes on missing properties */
+    if (ret!= ERROR_MORE_DATA)
+        return ERROR_SUCCESS;
+    else
+        return ret;
 }


More information about the wine-patches mailing list