dlls/shell32/shv_item_cmenu.c regression

Mike McCormack mike at codeweavers.com
Wed Jun 8 23:08:52 CDT 2005


Gerald Pfeifer wrote:
> After last night's updates, I'm no seeing the following warning in
> dlls/shell32/shv_item_cmenu.c
> 
>   shv_item_cmenu.c:203: warning: assignment discards qualifiers from 
>   pointer target type

Hello Gerald,

Perhaps you could have a go at fixing the warnings you see, rather than 
just complaining about them?  Seems like it would be equally easy, and 
save a few mails back and forth.

The warning can be fixed by applying the following patch.  This line was 
in the original patch, but Alexandre must have disliked the cast, so he 
removed it.

Mike


ChangeLog:
* add a cast to get rid of a warning
-------------- next part --------------
Index: dlls/shell32/shv_item_cmenu.c
===================================================================
RCS file: /home/wine/wine/dlls/shell32/shv_item_cmenu.c,v
retrieving revision 1.32
diff -u -p -r1.32 shv_item_cmenu.c
--- dlls/shell32/shv_item_cmenu.c	7 Jun 2005 20:30:30 -0000	1.32
+++ dlls/shell32/shv_item_cmenu.c	9 Jun 2005 04:06:55 -0000
@@ -200,7 +200,7 @@ void WINAPI _InsertMenuItem (
 	else
 	{
 	  mii.fMask = MIIM_ID | MIIM_TYPE | MIIM_STATE;
-	  mii.dwTypeData = dwTypeData;
+	  mii.dwTypeData = (LPSTR) dwTypeData;
 	  mii.fState = fState;
 	}
 	mii.wID = wID;


More information about the wine-patches mailing list