TREEVIEW_DoSelectItem should not do TVGN_FIRSTVISIBLE work if selected item is NULL - resubmit

Evan Deaubl wine at warpedview.com
Sun Mar 13 12:30:46 CST 2005


The tabs got lost on the first submit, so the patch doesn't apply (that'll teach me
to copy from an editor and not a terminal window...).  Here's a corrected patch:

ChangeLog:
* TREEVIEW_DoSelectItem should not do any of the TVGN_FIRSTVISIBLE work if the newSelect parameter is NULL

diff -urN wine-20050310/dlls/comctl32/treeview.c wine-20050310.new/dlls/comctl32/treeview.c
--- wine-20050310/dlls/comctl32/treeview.c	2005-02-22 12:31:01.000000000 -0700
+++ wine-20050310.new/dlls/comctl32/treeview.c	2005-03-13 11:05:05.940619648 -0700
@@ -4242,9 +4242,12 @@
 	break;

     case TVGN_FIRSTVISIBLE:
-	TREEVIEW_EnsureVisible(infoPtr, newSelect, FALSE);
-	TREEVIEW_SetFirstVisible(infoPtr, newSelect, TRUE);
-	TREEVIEW_Invalidate(infoPtr, NULL);
+	if (newSelect != NULL)
+	{
+	    TREEVIEW_EnsureVisible(infoPtr, newSelect, FALSE);
+	    TREEVIEW_SetFirstVisible(infoPtr, newSelect, TRUE);
+	    TREEVIEW_Invalidate(infoPtr, NULL);
+	}
 	break;
     }





More information about the wine-patches mailing list