version.c: quiet FIXME on Mingw32 applications.

C. Scott Ananian cscott at cscott.net
Thu Mar 17 14:17:06 CST 2005


ChangeLog:
  - teach VERSION_GetLinkedDLLVersion about Mingw32 applications.

Wine currently emits:
  fixme:ver:VERSION_GetLinkedDLLVersion Unknown EXE OS version 4.0, please report!!
when an application complied with Mingw32 (for example, Wine's own test 
suite) is run.

The appended patch tells Wine to treat these apps as if they were WIN98 
applications (the default case, which is what's happening anyway).
Perhaps there's a better return value to use?
  --scott

operation AMTHUG SARANAC assassination shotgun Ft. Meade Nazi CABOUNCE 
AEFOXTROT Mossad TASS CIA EZLN SCRANGER JMTIDE IDEA SUMAC payment
                          ( http://cscott.net/ )

Index: dlls/ntdll/version.c
===================================================================
RCS file: /home/wine/wine/dlls/ntdll/version.c,v
retrieving revision 1.13
diff -u -p -r1.13 version.c
--- dlls/ntdll/version.c	10 Feb 2005 21:19:00 -0000	1.13
+++ dlls/ntdll/version.c	17 Mar 2005 19:43:04 -0000
@@ -368,6 +368,7 @@ static DWORD VERSION_GetSystemDLLVersion
   * 5.12/5.00/5.00/4.00  NT4+IE5         comctl32.dll
   * 5.12/5.00/5.00/4.00  Win98           calc
   * x.xx/5.00/5.00/4.00  win95/win98/NT4 IE5 files
+ * 2.38/4.00/1.00/4.00  Mingw32         applications compiled with mingw32
   */
  static DWORD VERSION_GetLinkedDllVersion(void)
  {
@@ -471,6 +472,7 @@ static DWORD VERSION_GetLinkedDllVersion
              switch(ophd->MajorImageVersion)
              {
              case 4 : return WIN98;  /* most apps will use this */
+            case 1 : return WIN98; /* this seems to be generated by Mingw32 */
              case 0 : return WIN95;
              }
              break;



More information about the wine-patches mailing list