dlls/msi/tests - Windows 98 fix

Jakob Eriksson jakov at vmlinux.org
Mon Mar 21 08:22:46 CST 2005




Windows 98 doesn't like it when we delete the tempfile.
I think it's because it's open.



-------------- next part --------------
Index: dlls/msi/tests/record.c
===================================================================
RCS file: /home/wine/wine/dlls/msi/tests/record.c,v
retrieving revision 1.5
diff -u -r1.5 record.c
--- dlls/msi/tests/record.c	31 Jan 2005 11:30:59 -0000	1.5
+++ dlls/msi/tests/record.c	21 Mar 2005 14:20:50 -0000
@@ -239,7 +239,8 @@
     ok(r == ERROR_SUCCESS, "failed to add stream to record\n");
     r = MsiRecordReadStream(h, 1, buf, NULL);
     ok(r == ERROR_INVALID_PARAMETER, "should return error\n");
-    ok(DeleteFile(filename), "failed to delete stream temp file\n");
+    /* http://test.winehq.org/data/200503181000/98_jmelgarejo98casa/msi:record.txt */
+    DeleteFile(filename); /* Windows 98 doesn't like this at all, so don't check return. */
     r = MsiRecordReadStream(h, 1, NULL, NULL);
     ok(r == ERROR_INVALID_PARAMETER, "should return error\n");
     sz = sizeof buf;
@@ -282,6 +283,7 @@
     /* now close the stream record */
     r = MsiCloseHandle(h);
     ok(r == ERROR_SUCCESS, "Failed to close handle\n");
+    DeleteFile(filename); /* Delete it for sure, when everything else is closed. */
 }
 
 START_TEST(record)


More information about the wine-patches mailing list