[LOSTWAGES]: suggest janitoral project, updates and W3 fixes
Mike McCormack
mike at codeweavers.com
Wed Mar 23 00:07:16 CST 2005
ChangeLog:
* suggest janitoral project, updates and W3 fixes
-------------- next part --------------
Index: templates/en/contributing.template
===================================================================
RCS file: /home/wine/lostwages/templates/en/contributing.template,v
retrieving revision 1.24
diff -u -p -r1.24 contributing.template
--- templates/en/contributing.template 16 Mar 2005 17:32:29 -0000 1.24
+++ templates/en/contributing.template 23 Mar 2005 06:06:06 -0000
@@ -58,7 +58,7 @@ knowledge of the Windows internals. Let
<h3>Web site maintenance</h3>
<p>If you feel like writing about Wine or coding in PHP your
contribution will be greatly appreciated. You can find current task that need work
- in our <a href="http://bugs.winehq.org/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&product=WineHQ.com&component=misc-web">Bugzilla</a>.
+ in our <a href="http://bugs.winehq.org/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&product=WineHQ.com&component=misc-web">Bugzilla</a>.
Getting started is really easy, just get the WineHQ sources by following the
instructions in our <a href="{$root}/site/cvs">CVS</a>
section and look at the files in templates/en. And to submit patches,
@@ -278,8 +278,8 @@ knowledge of the Windows internals. Let
<a name="doc_win_api"></a>
<h3>Documentation of the Windows API functions</h3>
- <p><h5>The main reason is that as MS moves to new APIs it tends to remove all documentation of the old ones (e.g. Win
- 3.1).</h5></p>
+ <h5>The main reason is that as MS moves to new APIs it tends to remove all documentation of the old ones (e.g. Win
+ 3.1).</h5>
<p>The goal is to write an independent documentation of the Windows API. Since we are re implementing all
this API it would be a good coding practice to also document what we implement. We should in particular
concentrate on aspects that are not very well covered in the 'official' documentation like discrepancies
Index: templates/en/janitorial.template
===================================================================
RCS file: /home/wine/lostwages/templates/en/janitorial.template,v
retrieving revision 1.73
diff -u -p -r1.73 janitorial.template
--- templates/en/janitorial.template 21 Mar 2005 16:02:23 -0000 1.73
+++ templates/en/janitorial.template 23 Mar 2005 06:06:06 -0000
@@ -7,7 +7,17 @@
Janitor's List</a>), and it's high time that we have one too.
What is there to clean up? Well, lots of things! :)
- <h2>Eliminate uses of strncpy/strncpyW</h2>
+ <h2>Remove HeapAlloc casts</h2>
+
+ Casting the return value of HeapAlloc and HeapReAlloc is unnecessary,
+ and should be avoided. All existing casts can be removed. You can
+ find them using:<p>
+
+ <tt>find . -name "*.[ch]" | xargs egrep "\) *Heap(Re)?Alloc"</tt>
+
+ As of the 23rd March 2005, there's 262 of these to be removed.
+
+ <h2>Check the usage of strncpy/strncpyW</h2>
<i>strncpy(dst,src,n)</i> has two subtle
<a href="http://weblogs.asp.net/oldnewthing/archive/2005/01/07.aspx">
@@ -42,22 +52,22 @@
</ul>
<p>
- <h2>Portability fixes<h2>
+ <h2>Portability fixes</h2>
<h3>Fix Wine to be compilable by a 64-bit compiler</h3>
- <ol>
+ <ul>
<li> Inspect and fix all public Win32 headers to match PSDK definitions.
<li> Make sure that pointers do not get truncated.
<li> Add support for Win64.
- </ol>
+ </ul>
<h3>Fix wrong assumptions in Wine about endianess</h3>
- <ol>
+ <ul>
<li> Inspect all Wine code and public headers to eliminate endianess dependent
constructs (low/high parts of a field, bit fileds), add WORDS_BIGENDIAN
when appropriate.
<li> Make sure that Wine code handles data in an endianess independent way.
- </ol>
+ </ul>
<h2>Code cleanup</h2>
@@ -76,7 +86,7 @@
aggregation, pUnkOuter should be checked to make it is NULL.<p>
This usually means adding code like the following at the top of the
- factory's CreateInstance method:
+ factory's CreateInstance method:<p>
<pre>
if( pUnkOuter )
return CLASS_E_NOAGGREGATION;
Index: templates/en/resources.template
===================================================================
RCS file: /home/wine/lostwages/templates/en/resources.template,v
retrieving revision 1.11
diff -u -p -r1.11 resources.template
--- templates/en/resources.template 19 Jan 2005 17:00:46 -0000 1.11
+++ templates/en/resources.template 23 Mar 2005 06:06:06 -0000
@@ -50,7 +50,7 @@
<big> X </big>
<ul>
<li><a href="http://www.rahul.net/kenton/xsites.html">X Sites</a> Ken Lee's list of all things X related
- <li><a href="http://www.motifzone.net/index.php?module=pagemaster&PAGE_user_op=view_page&PAGE_id=35&cont=xresources.html">X resource pages</a> courtesy of The Motif Zone
+ <li><a href="http://www.motifzone.net/index.php?module=pagemaster&PAGE_user_op=view_page&PAGE_id=35&cont=xresources.html">X resource pages</a> courtesy of The Motif Zone
<li><a href="http://www.motifzone.net/">The Motif Zone</a> Lots of solid X information, in addition to information about toolkits like Motif.
<li><a href="http://tronche.com/gui/x/icccm/">ICCCM</a> How X programs are
supposed to talk to each other
Index: templates/en/sending_patches.template
===================================================================
RCS file: /home/wine/lostwages/templates/en/sending_patches.template,v
retrieving revision 1.11
diff -u -p -r1.11 sending_patches.template
--- templates/en/sending_patches.template 9 Feb 2005 22:30:19 -0000 1.11
+++ templates/en/sending_patches.template 23 Mar 2005 06:06:06 -0000
@@ -31,6 +31,8 @@ to make sure it's not spam before they c
<li>Avoid unnecessarily changing the formatting of the code.
<li>Use standard C, avoid C++ comments and inline variable declarations.
+
+ <li>Read the diff and make sure it contains only what you want in it.
</ul>
<p>Accepted patches will appear in the <a href="{$root}/site/forums">wine-cvs</a> mailing list.
Index: templates/en/status.template
===================================================================
RCS file: /home/wine/lostwages/templates/en/status.template,v
retrieving revision 1.33
diff -u -p -r1.33 status.template
--- templates/en/status.template 7 Mar 2005 21:14:42 -0000 1.33
+++ templates/en/status.template 23 Mar 2005 06:06:06 -0000
@@ -28,7 +28,7 @@
</td>
<td>
- <table width="300" border=0 vspace=10 hspace=10 class=black>
+ <table width="300" border=0 class=black>
<tr class=black><td>
<p class=small><b class=inverse>Wine Status Menu</b></p>
</td></tr>
More information about the wine-patches
mailing list