ddraw: Do not report DDCAPS_OVERLAY and friends since overlays are not supported

Dmitry Timoshkov dmitry at codeweavers.com
Tue Aug 15 06:43:42 CDT 2006


Hello,

an app I'm working on calls IDirectDrawSurfaceImpl_UpdateOverlay and
crashes later on. A comment for that API states that overlays are not
supported, however ddraw reports DDCAPS_OVERLAY as a supported one.

This patch helps to avoid the crash.

Changelog:
    ddraw: Do not report DDCAPS_OVERLAY and friends since overlays
    are not supported.

--- cvs/hq/wine/dlls/ddraw/main.c	2006-08-15 14:51:45.000000000 +0900
+++ wine/dlls/ddraw/main.c	2006-08-15 20:14:34.000000000 +0900
@@ -249,10 +249,11 @@ DDRAW_Create(GUID *guid,
 
     /* Initialize the caps */
     This->caps.dwSize = sizeof(This->caps);
+/* do not report DDCAPS_OVERLAY and friends since we don't support overlays */
 #define BLIT_CAPS (DDCAPS_BLT | DDCAPS_BLTCOLORFILL | DDCAPS_BLTDEPTHFILL \
           | DDCAPS_BLTSTRETCH | DDCAPS_CANBLTSYSMEM | DDCAPS_CANCLIP	  \
           | DDCAPS_CANCLIPSTRETCHED | DDCAPS_COLORKEY			  \
-          | DDCAPS_COLORKEYHWASSIST | DDCAPS_OVERLAY | DDCAPS_OVERLAYSTRETCH |DDCAPS_ALIGNBOUNDARYSRC )
+          | DDCAPS_COLORKEYHWASSIST | DDCAPS_ALIGNBOUNDARYSRC )
 #define CKEY_CAPS (DDCKEYCAPS_DESTBLT | DDCKEYCAPS_SRCBLT)
 #define FX_CAPS (DDFXCAPS_BLTALPHA | DDFXCAPS_BLTMIRRORLEFTRIGHT	\
                 | DDFXCAPS_BLTMIRRORUPDOWN | DDFXCAPS_BLTROTATION90	\





More information about the wine-patches mailing list