msi: callers of alloc_msihandle should handle failure

Dan Kegel dank at kegel.com
Mon Aug 28 11:44:35 CDT 2006


[Hey, maybe this is what Alexandre wanted...]

This is independent of my other two msi patches.
After this patch, e.g. MsiDatabaseOpenView now returns
an error code on out-of-memory instead of succeeding
but returning a zero handle.
(I couldn't tell whether ERROR_OUTOFMEMORY or
ERROR_NOT_ENOUGH_MEMORY was right for this, so
I picked one arbitrarily.)

Changelog:
 msi: return ERROR_NOT_ENOUGH_MEMORY if alloc_msihandle fails

 action.c   |    4 ++++
 database.c |    2 ++
 msi.c      |    2 ++
 msiquery.c |    8 ++++++++
 package.c  |    6 ++++++
 preview.c  |    2 ++
 suminfo.c  |    2 ++
 7 files changed, 26 insertions(+)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: msi-handletable-errhand.patch
Type: text/x-patch
Size: 4130 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060828/7194c0dd/msi-handletable-errhand.bin


More information about the wine-patches mailing list