Static control [05/10]: Better STM_GETIMAGE

Michael Kaufmann hallo at michael-kaufmann.ch
Wed Jan 11 16:27:05 CST 2006


Changelog:
  - STM_GETIMAGE returns NULL if the given image type doesn't match the 
control's style
-------------- next part --------------
--- static-old.c	2006-01-11 22:41:02.000000000 +0100
+++ static.c	2006-01-11 22:42:26.000000000 +0100
@@ -201,6 +201,32 @@
 }
 
 /***********************************************************************
+ *           STATIC_GetImage
+ *
+ * Gets the bitmap for an SS_BITMAP control, the icon/cursor for an
+ * SS_ICON control or the enhanced metafile for an SS_ENHMETAFILE control.
+ */
+static HANDLE STATIC_GetImage( HWND hwnd, WPARAM wParam, DWORD style )
+{
+    switch(style & SS_TYPEMASK)
+    {
+        case SS_ICON:
+            if ((wParam != IMAGE_ICON) &&
+                (wParam != IMAGE_CURSOR)) return NULL;
+            break;
+        case SS_BITMAP:
+            if (wParam != IMAGE_BITMAP) return NULL;
+            break;
+        case SS_ENHMETAFILE:
+            if (wParam != IMAGE_ENHMETAFILE) return NULL;
+            break;
+        default:
+            return NULL;
+    }
+    return (HANDLE)GetWindowLongPtrW( hwnd, HICON_GWL_OFFSET );
+}
+
+/***********************************************************************
  *           STATIC_LoadIconA
  *
  * Load the icon for an SS_ICON control.
@@ -473,13 +499,11 @@
         return 0;
 
     case STM_GETIMAGE:
-        /* FIXME: Return NULL if wParam doesn't match the control's style.
-                  wParam is IMAGE_BITMAP, IMAGE_CURSOR, IMAGE_ENHMETAFILE
-                  or IMAGE_ICON */
+        return (LRESULT)STATIC_GetImage( hwnd, wParam, full_style );
+    
     case STM_GETICON16:
     case STM_GETICON:
-        /* FIXME: Return NULL if this control doesn't show an icon */
-        return GetWindowLongPtrW( hwnd, HICON_GWL_OFFSET );
+        return (LRESULT)STATIC_GetImage( hwnd, IMAGE_ICON, full_style );
 
     case STM_SETIMAGE:
         switch(wParam) {


More information about the wine-patches mailing list