unixfs: Fix ParseDisplayName
Michael Jung
mjung at iss.tu-darmstadt.de
Sat Jan 14 05:37:03 CST 2006
The call to SHBindToParent in UnixFolders' ParseDisplayName only succeeded by
incidence thus far. Our DesktopFolder implementation calls ParseDisplayName
always with a single subdirectory, which leads to a simple pidl.
SHBindToParent accordingly binds to an empty pidl, which corresponds to the
desktop. The Desktop's GetAttributesOf then calls SHELL32_GetItemAttributes,
which gets the Attributes directly from the pidl. Thus, we got the correct
result, although the pidl passed to SHBindToParent was only a relative one,
while it should be absolute. It breaks, if we root unixfs beneath MyComputer,
which behaves differently than the Desktop folder.
Changelog:
Build an absolute pidl to query attributes in UnixFolder::ParseDisplayName
Bye,
--
Michael Jung
mjung at iss.tu-darmstadt.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dlls_shell32_shfldr_unixfs_c.diff
Type: text/x-diff
Size: 1560 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060114/489c8243/dlls_shell32_shfldr_unixfs_c.diff
More information about the wine-patches
mailing list