[AppDB] Fix Bogus Distributions being submitted

[Tony Lambregts]

When a person was submiting a new test result if there was anything in the 
string field for a new distribution then a new distribution was created.

This should cut down on the amount of bogus distributions.

Change log: Fix creation of some bogus distributions

Files Changed: appsubmit.php testResults.php
-------------- next part --------------
Index: testResults.php
===================================================================
RCS file: /home/wine/appdb/testResults.php,v
retrieving revision 1.1
diff -u -r1.1 testResults.php
--- testResults.php	17 Oct 2005 03:59:24 -0000	1.1
+++ testResults.php	16 Jan 2006 05:56:29 -0000
@@ -27,22 +27,25 @@
         $oTest->GetOutputEditorValues(); // retrieve the values from the current $_REQUEST 
         if(empty($errors))
         {
-            $sDistribution = trim($_REQUEST['sDistribution']);
-            if(!empty($sDistribution))
+            if(!$_REQUEST['iDistributionId'])
             {
-                $oDistribution = new distribution();
-                $oDistribution->sName = $sDistribution;
-                $oDistribution->create();
-                $oTest->iDistributionId = $oDistribution->iDistributionId;
+                $sDistribution = trim($_REQUEST['sDistribution']);
+                if(!empty($sDistribution))
+                {
+                    $oDistribution = new distribution();
+                    $oDistribution->sName = $sDistribution;
+                    $oDistribution->create();
+                    $oTest->iDistributionId = $oDistribution->iDistributionId;
+                }
+            }
+            if($_REQUEST['sub'] == 'Submit')
+            {
+	        $oTest->create();
+            } else if($_REQUEST['sub'] == 'Resubmit')
+            {
+                $oTest->update(true);
+	        $oTest->ReQueue();
             }
-		if($_REQUEST['sub'] == 'Submit')
-		{
-	            $oTest->create();
-		} else if($_REQUEST['sub'] == 'Resubmit')
-		{
-	            $oTest->update(true);
-	            $oTest->ReQueue();
-		}
             redirect($_SERVER['PHP_SELF']);
         } else 
         {
Index: appsubmit.php
===================================================================
RCS file: /home/wine/appdb/appsubmit.php,v
retrieving revision 1.35
diff -u -r1.35 appsubmit.php
--- appsubmit.php	12 Nov 2005 04:37:48 -0000	1.35
+++ appsubmit.php	16 Jan 2006 05:56:29 -0000
@@ -181,14 +181,16 @@
             {
                  $oVersion->create();
             }
-
-            $sDistribution = trim($_REQUEST['sDistribution']);
-            if(!empty($sDistribution))
+            if(!$_REQUEST['iDistributionId'])
             {
-                $oDistribution = new distribution();
-                $oDistribution->sName = $sDistribution;
-                $oDistribution->create();
-                $oTest->iDistributionId = $oDistribution->iDistributionId;
+                $sDistribution = trim($_REQUEST['sDistribution']);
+                if(!empty($sDistribution))
+                {
+                    $oDistribution = new distribution();
+                    $oDistribution->sName = $sDistribution;
+                    $oDistribution->create();
+                    $oTest->iDistributionId = $oDistribution->iDistributionId;
+                }
             }
             $oTest->iVersionId = $oVersion->iVersionId;
             if(is_numeric($oTest->iTestingId))