wined3d: Remove superfluous breaks.
Jason Green
jave27 at gmail.com
Tue Jul 25 16:36:37 CDT 2006
Yep, my fault, and this patch is correct. Sorry about that. :-)
On the brightside, that situation should never happen anyway, but nice catch.
On 7/25/06, Michael Stefaniuc <mstefani at redhat.de> wrote:
> Jason,
> can you have a look over this patch and see if it is correct? Your
> latest patch to glsl_shader.c seems to have introduced those and Smatch
> was complaining about unreachable code.
>
> bye
> michael
> ---
> dlls/wined3d/glsl_shader.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c
> index 4aa8b5b..b3ae5cb 100644
> --- a/dlls/wined3d/glsl_shader.c
> +++ b/dlls/wined3d/glsl_shader.c
> @@ -1417,7 +1417,7 @@ void pshader_glsl_texm3x3tex(SHADER_OPCO
> case D3DSTT_CUBE: strcpy(dimensions, "Cube"); break;
> case D3DSTT_VOLUME: strcpy(dimensions, "3D"); break;
> default:
> - strcpy(dimensions, ""); break;
> + strcpy(dimensions, "");
> FIXME("Unrecognized sampler type: %#lx\n", stype);
> break;
> }
> @@ -1447,7 +1447,7 @@ void pshader_glsl_texm3x3spec(SHADER_OPC
> case D3DSTT_CUBE: strcpy(dimensions, "Cube"); break;
> case D3DSTT_VOLUME: strcpy(dimensions, "3D"); break;
> default:
> - strcpy(dimensions, ""); break;
> + strcpy(dimensions, "");
> FIXME("Unrecognized sampler type: %#lx\n", stype);
> break;
> }
> @@ -1568,7 +1568,7 @@ void pshader_glsl_texreg2rgb(SHADER_OPCO
> case D3DSTT_CUBE: strcpy(dimensions, "Cube"); break;
> case D3DSTT_VOLUME: strcpy(dimensions, "3D"); break;
> default:
> - strcpy(dimensions, ""); break;
> + strcpy(dimensions, "");
> FIXME("Unrecognized sampler type: %#lx\n", stype);
> break;
> }
> --
> 1.4.0
>
>
> --
> Michael Stefaniuc Tel.: +49-711-96437-199
> Sr. Network Engineer Fax.: +49-711-96437-111
> Red Hat GmbH Email: mstefani at redhat.com
> Hauptstaetterstr. 58 http://www.redhat.de/
> D-70178 Stuttgart
>
>
>
More information about the wine-patches
mailing list