[PATCH] [MciWave]: bogus free

Eric Pouech eric.pouech at wanadoo.fr
Wed Jun 14 14:35:18 CDT 2006


- fixed potential freeing of user's memory in MciWave
  open function (spotted by Peter Astrand)

A+
---

 dlls/mciwave/mciwave.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/dlls/mciwave/mciwave.c b/dlls/mciwave/mciwave.c
index 11733db..82b49bb 100644
--- a/dlls/mciwave/mciwave.c
+++ b/dlls/mciwave/mciwave.c
@@ -480,6 +480,8 @@ static LRESULT WAVE_mciOpen(MCIDEVICEID 
     wmw->dwStatus = MCI_MODE_NOT_READY;
     wmw->hFile = 0;
     memcpy(&wmw->openParms, lpOpenParms, sizeof(MCI_WAVE_OPEN_PARMSA));
+    /* will be set by WAVE_mciOpenFile */
+    wmw->openParms.lpstrElementName = NULL;
 
     TRACE("wDevID=%04X (lpParams->wDeviceID=%08X)\n", wDevID, lpOpenParms->wDeviceID);
 



More information about the wine-patches mailing list