Memory leak in server's read_process_memory handler

Ken Thomases ken at codeweavers.com
Fri Mar 24 01:26:51 CST 2006


The read_process_memory handler in server/process.c allocates a  
buffer for the reply data.  In the case where the read_process_memory 
() function succeeds, that buffer is set into the reply.  However, in  
the case where read_process_memory() fails, that buffer is leaked.

Changelog:
     Fixed leak: free buffer when read_process_memory() fails

Index: server/process.c
===================================================================
RCS file: /home/wine/wine/server/process.c,v
retrieving revision 1.159
diff -u -r1.159 process.c
--- server/process.c	6 Mar 2006 21:28:45 -0000	1.159
+++ server/process.c	24 Mar 2006 07:18:46 -0000
@@ -1068,7 +1068,7 @@
                  if (start_offset) memmove( buffer, (char *)buffer +  
start_offset, len );
                  set_reply_data_ptr( buffer, len );
              }
-            else len = 0;
+            else free( buffer );
          }
      }
      release_object( process );




More information about the wine-patches mailing list