[opengl] Catch BadMatch errors before they can occur.

Tomas Carnecky tom at dbservice.com
Fri Mar 24 05:06:55 CST 2006


This patch fixes the BadMatch error in create_glxpixmap() and in
wglMakeCurrent(). When such an error would occur, wglMakeCurrent() will
fail and its up to the application to handle it. It seems that if World
of Warcraft fails to activate the glx pixmap (offscreen drawable) then
it will use the lower left corner of the frontbuffer to render the
minimap to. I can see the minimap there for one frame whenever WoW has
to rerender the minimap (if I zoom in or out and if I change the zone).
I don't know how other applications will handle this, but I think it's
better to propagate the error to the application rather than produce the
X Error.

Oh, and this patch creates a new debug-channel 'swapbuffers' and puts
both opengl swapbuffers functions into it.

Changelog:
 - Catch BadMatch errors in create_pixmap() and wglMakeCurrent() before
they can occur.
 - Move the TRACE *Swap*Buffers() into a new debug channel 'swapbuffers'

tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wine-glx-pixmap.patch
Type: text/x-patch
Size: 7012 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060324/6779c38a/wine-glx-pixmap.patch


More information about the wine-patches mailing list