[PATCH 13/14] [DbgHelp]: callback info on module unloading

Eric Pouech eric.pouech at wanadoo.fr
Wed May 10 14:35:47 CDT 2006


- removed call to registered callback when unloading a module
  (first, native dbghelp doesn't do it, and it crashed windbg, likely
   because we got the undocumented arguments wrong)

A+
---

 dlls/dbghelp/module.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c
index 26b847a..9b138e3 100644
--- a/dlls/dbghelp/module.c
+++ b/dlls/dbghelp/module.c
@@ -520,9 +520,9 @@ BOOL module_remove(struct process* pcs, 
     HeapFree(GetProcessHeap(), 0, (char*)module->sources);
     HeapFree(GetProcessHeap(), 0, module->addr_sorttab);
     pool_destroy(&module->pool);
-    if (module->module.SymType != SymNone)
-        pcs_callback(pcs, CBA_SYMBOLS_UNLOADED, NULL);
-
+    /* native dbghelp doesn't invoke registered callback(,CBA_SYMBOLS_UNLOADED,) here
+     * so do we
+     */
     for (p = &pcs->lmodules; *p; p = &(*p)->next)
     {
         if (*p == module)




More information about the wine-patches mailing list