[ntdll 1/5] Remove tests that crash on XP and W2K3

Paul Vriens paul.vriens.wine at gmail.com
Tue Nov 21 02:24:05 CST 2006


Hi,

these 3 tests crash on XP and W2K3. I left them in for documentation's sake.

Changelog
  Remove tests that crash on XP and W2K3

Cheers,

Paul.
---
 dlls/ntdll/tests/string.c |   36 ++++++++++++++++++++++++------------
 1 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/dlls/ntdll/tests/string.c b/dlls/ntdll/tests/string.c
index 01e671e..0db37d8 100644
--- a/dlls/ntdll/tests/string.c
+++ b/dlls/ntdll/tests/string.c
@@ -411,28 +411,40 @@ static void test_ulongtow(void)
 	expected_wstr[pos] = ulong2str[0].Buffer[pos];
     } /* for */
     expected_wstr[LARGE_STRI_BUFFER_LENGTH] = '\0';
-    result = p_itow(ulong2str[0].value, NULL, 10);
-    ok(result == NULL,
-       "(test a): _itow(%d, NULL, 10) has result %p, expected: NULL\n",
-       ulong2str[0].value, result);
+
+    if (0) {
+        /* Crashes on XP and W2K3 */
+        result = p_itow(ulong2str[0].value, NULL, 10);
+        ok(result == NULL,
+           "(test a): _itow(%d, NULL, 10) has result %p, expected: NULL\n",
+           ulong2str[0].value, result);
+    }
 
     for (pos = 0; pos < LARGE_STRI_BUFFER_LENGTH; pos++) {
 	expected_wstr[pos] = ulong2str[0].Buffer[pos];
     } /* for */
     expected_wstr[LARGE_STRI_BUFFER_LENGTH] = '\0';
-    result = p_ltow(ulong2str[0].value, NULL, 10);
-    ok(result == NULL,
-       "(test b): _ltow(%d, NULL, 10) has result %p, expected: NULL\n",
-       ulong2str[0].value, result);
+
+    if (0) {
+        /* Crashes on XP and W2K3 */
+        result = p_ltow(ulong2str[0].value, NULL, 10);
+        ok(result == NULL,
+           "(test b): _ltow(%d, NULL, 10) has result %p, expected: NULL\n",
+           ulong2str[0].value, result);
+    }
 
     for (pos = 0; pos < LARGE_STRI_BUFFER_LENGTH; pos++) {
 	expected_wstr[pos] = ulong2str[0].Buffer[pos];
     } /* for */
     expected_wstr[LARGE_STRI_BUFFER_LENGTH] = '\0';
-    result = p_ultow(ulong2str[0].value, NULL, 10);
-    ok(result == NULL,
-       "(test c): _ultow(%d, NULL, 10) has result %p, expected: NULL\n",
-       ulong2str[0].value, result);
+
+    if (0) {
+        /* Crashes on XP and W2K3 */
+        result = p_ultow(ulong2str[0].value, NULL, 10);
+        ok(result == NULL,
+           "(test c): _ultow(%d, NULL, 10) has result %p, expected: NULL\n",
+           ulong2str[0].value, result);
+    }
 }
 
 #define ULL(a,b) (((ULONGLONG)(a) << 32) | (b))
-- 
1.4.4




More information about the wine-patches mailing list