appdb patch - added browse by rating functionality revised

EA Durbin ead1234 at hotmail.com
Sun Sep 10 19:08:14 CDT 2006


I have enclosed a revised patch addressing the following items.

>Don't the urls in the hrefs in index.php have to be surrounded by quotes?

>The defines in include/application.php should look like:
>define("PLATNUM_RATING", "Platnum");
>like http://us3.php.net/manual/en/function.define.php


>You should rename countAppsWithRating() to 'countWithRating()', same with 
>the
>other new function.  The usage of the functions makes it quite obvious that
>it is a static function of the class application.


>browse_by_rating.php has no limit on the number of applications displayed.  
>We
>need to be aware that displaying thousands of entries can take some time 
>and
>will drain on the server resources.  Can you see about using the function
>display_page_range() in include/util.php?  This should let you pretty 
>easily
>limit the number of applications per-page to some reasonable number.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 3787 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060910/30b7c28d/patch-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browse_by_rating.php
Type: application/x-php
Size: 6799 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060910/30b7c28d/browse_by_rating-0001.bin


More information about the wine-patches mailing list