X11DRV: fix fbconfig regression

Roderick Colenbrander thunderbird2k at gmx.net
Fri Sep 15 11:22:52 CDT 2006


with patch
> Hi,
> 
> During my opengl rewrite I caused a regression (bug 6205) in the opengl
> code. There's a piece of code which checks the GLX version and based on the
> GLX version certain GLX functions are loaded. In the rewrite some code got
> changed and I forgot to take those changes into account.
> 
> There's this check:
>      if ((!WineGLInfo.glxDirect && !strcmp("1.2",
> WineGLInfo.glxServerVersion)) ||
>          (WineGLInfo.glxDirect && !strcmp("1.2",
> WineGLInfo.glxClientVersion)))
> 
> When the if-statement is 'true' the GLX version is 1.2 and we should check
> for the GLX_SGIX_fbconfig extension. Else the version is 1.3 or newer and
> then certain functions are standard GLX functionality.
> 
> By accident I switched the contents of the if and else blocks. This code
> swaps it and fixed bug 6205.
> 
> Regards,
> Roderick Colenbrander
> -- 
> "Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ...
> Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail
> 

-- 
"Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ...
Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x11drv_fbconfig_fix.patch
Type: text/x-diff
Size: 1992 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060915/9be67c90/x11drv_fbconfig_fix-0001.bin


More information about the wine-patches mailing list