ole32: Void functions should not return a value

Andrew Talbot Andrew.Talbot at talbotville.com
Thu Apr 12 15:30:19 CDT 2007


Changelog:
    ole32: Void functions should not return a value.

diff -urN a/dlls/ole32/rpc.c b/dlls/ole32/rpc.c
--- a/dlls/ole32/rpc.c	2007-03-28 12:43:32.000000000 +0100
+++ b/dlls/ole32/rpc.c	2007-04-12 20:20:48.000000000 +0100
@@ -1352,7 +1352,7 @@
     TRACE("ipid = %s, iMethod = %d\n", debugstr_guid(&ipid), msg->ProcNum);
 
     params = HeapAlloc(GetProcessHeap(), 0, sizeof(*params));
-    if (!params) return RpcRaiseException(E_OUTOFMEMORY);
+    if (!params) RpcRaiseException(E_OUTOFMEMORY);
 
     hr = ipid_get_dispatch_params(&ipid, &apt, &params->stub, &params->chan,
                                   &params->iid, &params->iface);
@@ -1360,7 +1360,7 @@
     {
         ERR("no apartment found for ipid %s\n", debugstr_guid(&ipid));
         HeapFree(GetProcessHeap(), 0, params);
-        return RpcRaiseException(hr);
+        RpcRaiseException(hr);
     }
 
     params->msg = (RPCOLEMESSAGE *)msg;
diff -urN a/dlls/ole32/usrmarshal.c b/dlls/ole32/usrmarshal.c
--- a/dlls/ole32/usrmarshal.c	2007-03-27 13:00:25.000000000 +0100
+++ b/dlls/ole32/usrmarshal.c	2007-04-12 20:25:44.000000000 +0100
@@ -321,7 +321,7 @@
     void __RPC_USER type##_UserFree(ULONG *pFlags, type *handle) \
     { \
         TRACE("(%s, &%p\n", debugstr_user_flags(pFlags), *handle); \
-        return handle_UserFree(pFlags, (HANDLE *)handle); \
+        handle_UserFree(pFlags, (HANDLE *)handle); \
     }
 
 IMPL_WIREM_HANDLE(HACCEL)



More information about the wine-patches mailing list