SHGetFileInfo fix

Aric Stewart aric at codeweavers.com
Wed Apr 18 13:11:47 CDT 2007


the SHGFI_EXETYPE flag should have the files returning 0 if they are DLL 
images even if they are PE images because DLL files are still nonexecutable.
---
  dlls/shell32/shell32_main.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
-------------- next part --------------
diff --git a/dlls/shell32/shell32_main.c b/dlls/shell32/shell32_main.c
index 70db342..ea4b510 100644
--- a/dlls/shell32/shell32_main.c
+++ b/dlls/shell32/shell32_main.c
@@ -275,6 +275,9 @@ static DWORD shgfi_get_exe_type(LPCWSTR
         SetFilePointer( hfile, mz_header.e_lfanew, NULL, SEEK_SET );
         ReadFile( hfile, &nt, sizeof(nt), &len, NULL );
         CloseHandle( hfile );
+        /* DLL files are not executable and should return 0 */
+        if (nt.FileHeader.Characteristics & IMAGE_FILE_DLL)
+            return 0;
         if (nt.OptionalHeader.Subsystem == IMAGE_SUBSYSTEM_WINDOWS_GUI)
         {
              return IMAGE_NT_SIGNATURE | 


More information about the wine-patches mailing list