[PATCH] [bug9037] Show fixme when advpack fails to prompt user for directory

Jason Edmeades jason.edmeades at googlemail.com
Thu Aug 9 17:56:17 CDT 2007


Without this, the default installation directory is always used.
Some needs to code a advpack resource as per windows with a text entry
box, ok, cancel and browse buttons.... Any volunteers?
---
 dlls/advpack/advpack.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c
index ee3a87e..157413f 100644
--- a/dlls/advpack/advpack.c
+++ b/dlls/advpack/advpack.c
@@ -116,6 +116,7 @@ void set_ldids(HINF hInf, LPCWSTR pszInstallSection, LPCWSTR pszWorkingDir)
     do
     {
         LPWSTR value, ptr, key, key_copy = NULL;
+        DWORD flags = 0;
 
         SetupGetLineTextW(&context, NULL, NULL, NULL,
                           line, MAX_FIELD_LENGTH, &size);
@@ -141,10 +142,12 @@ void set_ldids(HINF hInf, LPCWSTR pszInstallSection, LPCWSTR pszWorkingDir)
         while (*value == ' ')
             value++;
 
-        /* FIXME: need to check the query option */
+        /* Extract the flags */
         ptr = strchrW(value, ',');
-        if (ptr)
+        if (ptr) {
             *ptr = '\0';
+            flags = atolW(ptr+1);
+        }
 
         /* set dest to pszWorkingDir if key is SourceDir */
         if (pszWorkingDir && !lstrcmpiW(value, source_dir))
@@ -152,6 +155,10 @@ void set_ldids(HINF hInf, LPCWSTR pszInstallSection, LPCWSTR pszWorkingDir)
         else
             get_dest_dir(hInf, value, dest, MAX_PATH);
 
+        /* If prompting required, provide dialog to request path */
+        if (flags & 0x04)
+            FIXME("Need to support changing paths - default will be used\n");
+
         /* set all ldids to dest */
         while ((ptr = get_parameter(&key, ',')))
         {
-- 
1.5.0




More information about the wine-patches mailing list