[PATCH] WCMD_for is only for files

Marcus Meissner marcus at jet.franken.de
Sun Aug 12 14:22:41 CDT 2007


isDirs is only assigned once, and never changed.

So the if() can be simplified.

spotted by Coverity.

Ciao, Marcus
---
 programs/cmd/builtins.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c
index d887c4f..1228206 100644
--- a/programs/cmd/builtins.c
+++ b/programs/cmd/builtins.c
@@ -654,7 +654,6 @@ void WCMD_for (WCHAR *p, CMD_LIST **cmdL
   WCHAR variable[4];
   WCHAR *firstCmd;
   int thisDepth;
-  BOOL isDirs = FALSE;
 
   /* Check:
      the first line includes the % variable name as first parm
@@ -730,8 +729,7 @@ void WCMD_for (WCHAR *p, CMD_LIST **cmdL
         if (hff != INVALID_HANDLE_VALUE) {
           do {
             BOOL isDirectory = (fd.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY);
-            if ((isDirs && isDirectory) ||
-                (!isDirs && !isDirectory))
+            if (!isDirectory)
             {
               thisCmdStart = cmdStart;
               WINE_TRACE("Processing FOR filename %s\n", wine_dbgstr_w(fd.cFileName));
-- 
1.4.3.4



More information about the wine-patches mailing list