[PATCH] Support for animated cursors

Trent Waddington trent.waddington at gmail.com
Tue Aug 28 17:59:51 CDT 2007


On 8/29/07, Juan Lang <juan.lang at gmail.com> wrote:
> Like Henri already said, you really can't use globals for anih,
> ani_frames, and ani_frame_idx.  These should be in a structure, and
> decodeRIFF should write into that structure, not into globals.  The
> structure should then be associated with the icon.

They're temps.. I've added a comment to make that clear.

> This may be obvious to other, but certainly not to me:  what does
> 0x00030000 mean?  You need to use symbolic constants here.

It's the version non-sense that Microsoft's api requires.  You'll find
that every call to this api and it's non-Ex variant have it.

> Please don't include dead code.

Doh, sorry.  Removed.

Trent
-------------- next part --------------
A non-text attachment was scrubbed...
Name: animated_cursors.patch
Type: application/octet-stream
Size: 11832 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070829/29ef7ed7/animated_cursors-0001.obj


More information about the wine-patches mailing list